Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: sql: disallow partial index creation referencing new column in predicate #82670

Merged
merged 1 commit into from
Jun 9, 2022
Merged

release-21.2: sql: disallow partial index creation referencing new column in predicate #82670

merged 1 commit into from
Jun 9, 2022

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Jun 9, 2022

Backport 1/1 commits from #79691.

/cc @cockroachdb/release

Release note (bug fix): Previously, when adding a column to a pre-existing
table and adding a partial index referencing that column in the
transaction, DML operations against the table while the schema change was
ongoing would fail. Now these hazardous schema changes are not allowed.

Release justification: This commit prevents hazardous results when adding
a partial index to a table.

@ajwerner @mgartner
sql: disallow partial index creation referencing new column in predicate
ade92c0 
Release note (bug fix): Previously, when adding a column to a pre-existing
table and adding a partial index referencing that column in the
transaction, DML operations against the table while the schema change was
ongoing would fail. Now these hazardous schema changes are not allowed.
@mgartner mgartner requested a review from a team June 9, 2022 15:02
@blathers-crl
Copy link

blathers-crl bot commented Jun 9, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@mgartner mgartner requested a review from ajwerner June 9, 2022 15:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: though I still worry somebody is going to be sad about it.

Thanks for doing it and sorry I didn't ☹️

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@mgartner
Copy link
Collaborator Author

mgartner commented Jun 9, 2022

TFTR!

@mgartner mgartner merged commit 51fa3cf into cockroachdb:release-21.2 Jun 9, 2022
@mgartner mgartner deleted the backport21.2-79691 branch June 9, 2022 16:08
@ajwerner ajwerner mentioned this pull request Jul 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgartner @cockroach-teamcity @ajwerner